This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Merged
Conversation
daviddias
force-pushed
the
feat/blocks
branch
from
128f946 to
8836e17
Compare
daviddias
force-pushed
the
feat/blocks
branch
from
8836e17 to
b042d74
Compare
Merged
Add json loader
Member
Author
|
tests/test-core/test-block.js
Outdated
Member
Author
There was a problem hiding this comment.
bug found (this took me a bit to figure out :))
When using raw-loader, a string is returned with the contents of the file, if the file content was text, it would be ok, but since it is an encoded protobuf, it will add extra encoding data (utf8) adding extra bytes to the content of the Buffer, increasing the size of the Block and by so, failing the test. Need to get another way to load the blocks into localstorage
Member
There was a problem hiding this comment.
Maybe this could work for you? https://github.com/martijnvermaat/binary-loader
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #50